Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5950
  
    @StefanRRichter I have updated the PR. Also had to do a rebase due to 
conflicts.
    
    Regarding the thoughts you brought up:
    - Bubble up `UnloadableTypeSerializerException` approach:
    I introduced the exception, but only use it minimally. I think overall it 
is definitely an improvement, since we don't have to carry the dummy flag all 
the way down to the low-level serializer serialization proxy. However, I don't 
think there really is a need to handle it any level higher than the 
`TypeSerializerSerializationUtil.readSerializersAndConfigsWithResilience` 
method, since the original intent of that method was to always be fault 
tolerant when reading a bunch of serializers alongside other things. More 
details on that in my above comments.
    
    - Whether or not we really need to hand down the flag to 
`KeyedBackendSerializationProxy`:
    My gut feeling is that, even if in the future we bubble up the 
`UnloadableTypeSerializerException` to higher level components, the 
serialization proxy is still where we need to decide whether or not we handle 
it with a dummy serializer. The reason is that the serialization proxies 
handles deserialization of _all_ keyed state meta infos (and therefore their 
serializers); simply bubbling the exception further up without checking does 
not make sense.


---

Reply via email to