Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5950#discussion_r185995278
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSerializationUtil.java
---
@@ -200,7 +197,7 @@ public static void
writeSerializersAndConfigsWithResilience(
for (int i = 0; i < numSerializersAndConfigSnapshots;
i++) {
bufferWithPos.setPosition(offsets[i * 2]);
- serializer = tryReadSerializer(bufferWrapper,
userCodeClassLoader);
+ serializer = tryReadSerializer(bufferWrapper,
userCodeClassLoader, true);
--- End diff --
One other thing to keep in mind:
The original intent of having the
`readSerializersAndConfigSnapshotsWithResilience` method and why we added the
complex indexing of offsets, is that so we can _always_ be fault tolerant when
trying to read a bunch of serializers. So, essentially, there is no need to
push out the exception further - the result of
`readSerializersAndConfigSnapshotsWithResilience` should always be that there
is some serializer, even if it is a dummy (hence the naming).
---
