Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r191147297
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java 
---
    @@ -72,10 +72,19 @@
                        " leader-election service (like ZooKeeper) is used to 
elect and discover the JobManager" +
                        " leader from potentially multiple standby 
JobManagers.");
     
    +   /**
    +    * JVM heap size for the JobManager with memory size.
    +    */
    +   public static final ConfigOption<String> JOB_MANAGER_HEAP_MEMORY =
    +           key("jobmanager.heap.size")
    +           .defaultValue("1024m")
    +           .withDescription("JVM heap size for the JobManager.");
    +
        /**
         * JVM heap size (in megabytes) for the JobManager.
    +    * @deprecated use {@link #JOB_MANAGER_HEAP_MEMORY}
         */
    -   public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY =
    +   public static final ConfigOption<Integer> JOB_MANAGER_HEAP_MEMORY_MB =
    --- End diff --
    
    Missing annotation `@Deprecated`. That way we can remove that option from 
docs (which I think we should do).


---

Reply via email to