[GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r191197602
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -647,7 +649,16 @@ public static long calculateHeapSizeMB(long 
totalJavaMemorySizeMB, Configuration
                final long heapSizeMB;
                if (useOffHeap) {
     
    -                   long offHeapSize = 
config.getLong(TaskManagerOptions.MANAGED_MEMORY_SIZE);
    +                   String managedMemorySizeDefaultVal = 
TaskManagerOptions.MANAGED_MEMORY_SIZE.defaultValue();
    +                   long offHeapSize = 0;
    +                   try {
    +                           offHeapSize = 
Long.valueOf(managedMemorySizeDefaultVal);
    +                           if 
(!config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE).equals(managedMemorySizeDefaultVal))
 {
    +                                   offHeapSize = 
MemorySize.parse(config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE)).getMebiBytes();
    +                           }
    +                   } catch (IllegalArgumentException e) {
    +
    --- End diff --
    
    Rethrow with IllegalConfigurationException with a pointer that 
`MANAGED_MEMORY_SIZE` was badly configured.


---