[
https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494937#comment-16494937
]
ASF GitHub Bot commented on FLINK-3952:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191700141
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBuffer.java
---
@@ -424,6 +480,19 @@ public int setBytes(int index, ScatteringByteChannel
in, int length) throws IOEx
}
}
+ @Override
+ public int setBytes(int index, FileChannel in, long position, int
length) throws IOException {
+ // adapted from UnpooledDirectByteBuf:
+ checkIndex(index, length);
+
+ ByteBuffer tmpBuf = memorySegment.wrap(index, length);
+ try {
+ return in.read(tmpBuf);
--- End diff --
ops, good catch. Even better catch is that this was not covered by any
test, because I assumed `AbstractByteBufTest` comes from netty, while in
reality it was copied to our code.
Fixed this lack of `position` bug and upgraded the `AbstractByteBufTest` as
well - newer version was correctly failing with this bug.
> Bump Netty to 4.1
> -----------------
>
> Key: FLINK-3952
> URL: https://issues.apache.org/jira/browse/FLINK-3952
> Project: Flink
> Issue Type: Improvement
> Components: Core, Network
> Reporter: rektide de la fey
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of
> significant
> enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in
> particular I find HTTP/2 codecs to be incredibly desirable to have.
> Additionally, hopefully, the [Hadoop patches for Netty
> 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and
> get merged, & I believe if/when that happens it'll be important for Flink to
> also be using the new Netty minor version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
