[
https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509368#comment-16509368
]
ASF GitHub Bot commented on FLINK-3952:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194660815
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
---
@@ -75,12 +75,12 @@ private ReadOnlySlicedNetworkBuffer(ByteBuf buffer, int
index, int length, int m
@Override
public ByteBuf unwrap() {
- return super.unwrap().unwrap();
+ return super.unwrap();
--- End diff --
But isn't it a bit counter-intuitive that you instantiate a
`ReadOnlySlicedNetworkBuffer` with a `NetworkBuffer` and when you call
`ReadOnlySlicedNetworkBuffer.unwrap` you don't get a `NetworkBuffer` back but a
`SlicedByteBuf`? Thus, you need to know the internals of this class to know
that you have to call twice `unwrap` to obtain the `NetworkBuffer`. This shows
for example in the `NetworkBufferTest` where we always call
`slice.unwrap().unwrap()`.
What exactly did change with the structure of nested classes that this
change is necessary?
> Bump Netty to 4.1
> -----------------
>
> Key: FLINK-3952
> URL: https://issues.apache.org/jira/browse/FLINK-3952
> Project: Flink
> Issue Type: Improvement
> Components: Core, Network
> Reporter: rektide de la fey
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of
> significant
> enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in
> particular I find HTTP/2 codecs to be incredibly desirable to have.
> Additionally, hopefully, the [Hadoop patches for Netty
> 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and
> get merged, & I believe if/when that happens it'll be important for Flink to
> also be using the new Netty minor version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
