[
https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509383#comment-16509383
]
ASF GitHub Bot commented on FLINK-3952:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194666612
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/AbstractByteBufTest.java
---
@@ -64,12 +69,13 @@
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeFalse;
import static org.junit.Assume.assumeTrue;
/**
* An abstract test class for channel buffers.
*
- * Copied from netty 4.0.50 with some changes to fit our netty version
4.0.27.
+ * Copy from netty 4.1.24.Final.
*/
public abstract class AbstractByteBufTest {
--- End diff --
Let's extend this class from `TestLogger`.
> Bump Netty to 4.1
> -----------------
>
> Key: FLINK-3952
> URL: https://issues.apache.org/jira/browse/FLINK-3952
> Project: Flink
> Issue Type: Improvement
> Components: Core, Network
> Reporter: rektide de la fey
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of
> significant
> enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in
> particular I find HTTP/2 codecs to be incredibly desirable to have.
> Additionally, hopefully, the [Hadoop patches for Netty
> 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and
> get merged, & I believe if/when that happens it'll be important for Flink to
> also be using the new Netty minor version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
