Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r198142339
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
@@ -98,10 +98,12 @@ object TableSourceFactoryService extends Logging {
plainContext.remove(STATISTICS_PROPERTY_VERSION)
// check if required context is met
- if (plainContext.forall(e => properties.contains(e._1) &&
properties(e._1) == e._2)) {
+ if
(properties.get(TableDescriptorValidator.TABLE_TYPE).get.equals(factory.tableType())
&&
--- End diff --
Consider cases where the type has not been set. Btw
`properties.get(TableDescriptorValidator.TABLE_TYPE).get` can be simplified to
`properties(TableDescriptorValidator.TABLE_TYPE)`. It might be useful to enable
more warnings in your IDE.
---
