Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r198146766
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
@@ -141,22 +143,26 @@ object TableSourceFactoryService extends Logging {
// check for supported properties
plainProperties.foreach { k =>
- if (!supportedProperties.contains(k)) {
+ if (!k.equals(TableDescriptorValidator.TABLE_TYPE) &&
!supportedProperties.contains(k)) {
throw new ValidationException(
s"Table factory '${factory.getClass.getCanonicalName}' does not
support the " +
- s"property '$k'. Supported properties are: \n" +
-
s"${supportedProperties.map(DescriptorProperties.toString).mkString("\n")}")
+ s"property '$k'. Supported properties are: \n" +
+
s"${supportedProperties.map(DescriptorProperties.toString).mkString("\n")}")
}
}
- // create the table source
+ // create the table connector
try {
factory.create(properties.asJava)
} catch {
case t: Throwable =>
throw new TableException(
- s"Table source factory '${factory.getClass.getCanonicalName}'
caused an exception.",
+ s"Table connector factory '${factory.getClass.getCanonicalName}'
caused an exception.",
--- End diff --
There are more exception messages in this class that need an update.
---
