Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r198136187
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactory.scala
---
@@ -16,21 +16,18 @@
* limitations under the License.
*/
-package org.apache.flink.table.sources
+package org.apache.flink.table.connector
import java.util
-/**
- * A factory to create a [[TableSource]]. This factory is used with
Java's Service Provider
- * Interfaces (SPI) for discovering. A factory is called with a set of
normalized properties that
- * describe the desired table source. The factory allows for matching to
the given set of
- * properties and creating a configured [[TableSource]] accordingly.
- *
- * Classes that implement this interface need to be added to the
- * "META_INF/services/org.apache.flink.table.sources.TableSourceFactory'
file of a JAR file in
- * the current classpath to be found.
- */
-trait TableSourceFactory[T] {
+trait TableConnectorFactory[T] {
+ /**
+ * Specify the type of the table connector, check
+ * [[org.apache.flink.table.descriptors.TableDescriptorValidator]] for
all values.
+ *
+ * @return the table connector type,.
+ */
+ def tableType() : String
--- End diff --
Rename to `getType()`?
---
