[
https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526539#comment-16526539
]
ASF GitHub Bot commented on FLINK-9456:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r198493145
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
---
@@ -1202,6 +1209,111 @@ public void testSlotRequestFailure() throws
Exception {
}
}
+ /**
+ * Tests notify the job manager when the task manager is failed/killed.
+ */
+ @Test
+ public void testNotifyTaskManagerFailed() throws Exception {
+
+ final List<Tuple4<JobID, ResourceID, Set<AllocationID>,
Exception>> notifiedTaskManagerInfos = new ArrayList<>();
+
+ try (final SlotManager slotManager =
createSlotManager(ResourceManagerId.generate(), new TestingResourceActions() {
+ @Override
+ public void notifyTaskManagerTerminated(JobID jobId,
ResourceID resourceID, Set<AllocationID> allocationIDs, Exception cause) {
+ notifiedTaskManagerInfos.add(new
Tuple4<>(jobId, resourceID, allocationIDs, cause));
+ }
+ })) {
--- End diff --
Indentation looks a bit off here
> Let ResourceManager notify JobManager about failed/killed TaskManagers
> ----------------------------------------------------------------------
>
> Key: FLINK-9456
> URL: https://issues.apache.org/jira/browse/FLINK-9456
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> Often, the {{ResourceManager}} learns faster about TaskManager
> failures/killings because it directly communicates with the underlying
> resource management framework. Instead of only relying on the
> {{JobManager}}'s heartbeat to figure out that a {{TaskManager}} has died, we
> should additionally send a signal from the {{ResourceManager}} to the
> {{JobManager}} if a {{TaskManager}} has died. That way, we can react faster
> to {{TaskManager}} failures and recover our running job/s.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
