[
https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526533#comment-16526533
]
ASF GitHub Bot commented on FLINK-9456:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r198910651
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java
---
@@ -53,4 +56,13 @@
* @param cause of the allocation failure
*/
void notifyAllocationFailure(JobID jobId, AllocationID allocationId,
Exception cause);
+
+ /**
+ * Notifies that the task manager has been terminated.
+ * @param jobId to be notified
+ * @param resourceID identifying the terminated task manager
+ * @param allocationIDs of the job held that belong to this task manager
+ * @param cause of the task manager termination.
+ */
+ void notifyTaskManagerTerminated(JobID jobId, ResourceID resourceID,
Set<AllocationID> allocationIDs, Exception cause);
--- End diff --
I think the notification about a terminated `TaskManager` should not come
from the `SlotManager` but from the `ResourceManager`. Thus, we should not need
this method.
> Let ResourceManager notify JobManager about failed/killed TaskManagers
> ----------------------------------------------------------------------
>
> Key: FLINK-9456
> URL: https://issues.apache.org/jira/browse/FLINK-9456
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> Often, the {{ResourceManager}} learns faster about TaskManager
> failures/killings because it directly communicates with the underlying
> resource management framework. Instead of only relying on the
> {{JobManager}}'s heartbeat to figure out that a {{TaskManager}} has died, we
> should additionally send a signal from the {{ResourceManager}} to the
> {{JobManager}} if a {{TaskManager}} has died. That way, we can react faster
> to {{TaskManager}} failures and recover our running job/s.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
