[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

[pnowojski]

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202421703
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
 ---
    @@ -371,6 +416,13 @@ public void stop(SessionContext session) {
                        result.isMaterialized());
        }
     
    +   /**
    +    * Creates a table using the given query in the given table environment.
    +    *
    +    * @param tableEnv table environment
    +    * @param query SQL SELECT query
    +    * @return result table object
    +    */
        private Table createTable(TableEnvironment tableEnv, String query) {
    --- End diff --
    
    rename `query` -> `selectQuery` and drop `@param` section from java doc?


---