Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202507930
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
 ---
    @@ -354,6 +398,23 @@ private void callSelect(SqlCommandCall cmdCall) {
                }
        }
     
    +   private boolean callInsertInto(SqlCommandCall cmdCall) {
    +           
terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_SUBMITTING_STATEMENT).toAnsi());
    +           terminal.flush();
    +
    +           try {
    +                   final ProgramTargetDescriptor programTarget = 
executor.executeUpdate(context, cmdCall.operands[0]);
    +                   
terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_STATEMENT_SUBMITTED).toAnsi());
    --- End diff --
    
    Initially I had it similar like your proposal, but this would mix a data 
model class and visualization. `ProgramTargetDescriptor` should not be 
responsible how it is represented in the CLI.


---

Reply via email to