Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202507962
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
---
@@ -329,14 +341,46 @@ public void stop(SessionContext session) {
}
}
- private <T> ResultDescriptor executeQueryInternal(ExecutionContext<T>
context, String query) {
+ private <C> ProgramTargetDescriptor
executeUpdateInternal(ExecutionContext<C> context, String statement) {
+ final ExecutionContext.EnvironmentInstance envInst =
context.createEnvironmentInstance();
+
+ // apply update statement
--- End diff --
On one side yes but on the other side it allows to read the comments from
top to bottom and know what the method is doing without having to look at the
actual code.
---
