[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544667#comment-16544667
 ] 

ASF GitHub Bot commented on FLINK-9489:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6333#discussion_r202552705
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
 ---
    @@ -24,37 +24,46 @@
     import org.apache.flink.util.Preconditions;
     
     import javax.annotation.Nonnull;
    +import javax.annotation.Nullable;
     
     import java.util.Collections;
     import java.util.HashMap;
     import java.util.Map;
     import java.util.Objects;
     
    -public class RegisteredBroadcastBackendStateMetaInfo<K, V> extends 
RegisteredStateMetaInfoBase {
    +public class RegisteredBroadcastStateBackendMetaInfo<K, V> extends 
RegisteredStateMetaInfoBase {
     
        /** The mode how elements in this state are assigned to tasks during 
restore. */
    +   @Nonnull
        private final OperatorStateHandle.Mode assignmentMode;
     
        /** The type serializer for the keys in the map state. */
    +   @Nonnull
        private final TypeSerializer<K> keySerializer;
     
        /** The type serializer for the values in the map state. */
    +   @Nonnull
        private final TypeSerializer<V> valueSerializer;
     
    -   public RegisteredBroadcastBackendStateMetaInfo(
    -                   final String name,
    -                   final OperatorStateHandle.Mode assignmentMode,
    -                   final TypeSerializer<K> keySerializer,
    -                   final TypeSerializer<V> valueSerializer) {
    +   /** The precomputed immutable snapshot of this state */
    +   @Nullable
    +   private StateMetaInfoSnapshot precomputedSnapshot;
    --- End diff --
    
    nit: Maybe rename to `precomputedStateMetaInfoSnapshot`


> Checkpoint timers as part of managed keyed state instead of raw keyed state
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-9489
>                 URL: https://issues.apache.org/jira/browse/FLINK-9489
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Timer state should now become part of the keyed state backend snapshot, i.e., 
> stored inside the managed keyed state. This means that we have to connect our 
> preparation for asynchronous checkpoints with the backend, so that the timers 
> are written as part of the state for each key-group. This means that we will 
> also free up the raw keyed state an might expose it to user functions in the 
> future.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)