[ 
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544693#comment-16544693
 ] 

ASF GitHub Bot commented on FLINK-9489:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6333#discussion_r202556091
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
 ---
    @@ -446,8 +485,10 @@ public String toString() {
        @Override
        public int numStateEntries() {
                int sum = 0;
    -           for (StateTable<K, ?, ?> stateTable : stateTables.values()) {
    -                   sum += stateTable.size();
    +           for (StateSnapshotRestore stateTable : 
registeredStates.values()) {
    +                   if (stateTable instanceof StateTable) {
    +                           sum += ((StateTable<?, ?, ?>) 
stateTable).size();
    +                   }
    --- End diff --
    
    This method is only used for some tests, and to be on the safe side it 
probably only expected to count the keyed state and not some timers.


> Checkpoint timers as part of managed keyed state instead of raw keyed state
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-9489
>                 URL: https://issues.apache.org/jira/browse/FLINK-9489
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Timer state should now become part of the keyed state backend snapshot, i.e., 
> stored inside the managed keyed state. This means that we have to connect our 
> preparation for asynchronous checkpoints with the backend, so that the timers 
> are written as part of the state for each key-group. This means that we will 
> also free up the raw keyed state an might expose it to user functions in the 
> future.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to