Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/6297
  
    Changes look good now. I think we are still missing tests for the added 
behaviour. We should check:
    
    - if yarn cli parameters are properly parsed without units
    - if yarn cli parameters are properly parsed with units other than m
    - if the logic for `getJobManagerHeapMemory/getTaskManagerHeapMemory` works 
properly (if the old parameter is parsed if the new one is not provided. If the 
default value is provided if no option was set.


---

Reply via email to