[GitHub] flink pull request #6297: [FLINK-9777] YARN: JM and TM Memory must be specif...

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6297#discussion_r202339002
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -500,11 +501,11 @@ protected Configuration 
applyCommandLineOptionsToConfiguration(CommandLine comma
                }
     
                if (commandLine.hasOption(jmMemory.getOpt())) {
    -                   
effectiveConfiguration.setString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY, 
commandLine.getOptionValue(jmMemory.getOpt()));
    +                   
effectiveConfiguration.setString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY, 
commandLine.getOptionValue(jmMemory.getOpt()) + "m");
                }
     
                if (commandLine.hasOption(tmMemory.getOpt())) {
    -                   
effectiveConfiguration.setString(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY, 
commandLine.getOptionValue(tmMemory.getOpt()));
    +                   
effectiveConfiguration.setString(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY, 
commandLine.getOptionValue(tmMemory.getOpt()) + "m");
    --- End diff --
    
    Same as above.


---