Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202071052
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
createClusterSpecification(Configuration configurat
}
// JobManager Memory
- final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
+ final int jobManagerMemoryMB =
MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY),
MemorySize.MemoryUnit.MEGA_BYTES).getMebiBytes();
--- End diff --
to @GJL we can not use `.withDeprecatedKeys("jobmanager.heap.mb")` because
`jobmanager.heap.size` and `jobmanager.heap.mb` has different meaning. The
former can use different unit such **1g** but the latter can just measure with
**MB**.
to @dawidwys and @GJL , now the `jobmanager.heap.mb` just used in config
file, and can be calculated accurately, this is used for backwards
compatibility, but in the project, it is useless, all the place can be replaced
with `jobmanager.heap.size`, and the key in the code could not been exposed to
the user?
---
