[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555179#comment-16555179
]
ASF GitHub Bot commented on FLINK-9941:
---------------------------------------
GitHub user Lemonjing opened a pull request:
https://github.com/apache/flink/pull/6411
[FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to
ensure CI stability
## What is the purpose of the change
This pull request update scala api `ScalaCsvOutputFormat` to increase CI
stability.
## Brief change log
Add flush method before close function in ScalaCsvOutputFormat for scala
API.
## Verifying this change
This change is already covered by existing tests, such as
ScalarFunctionsTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
Does this pull request introduce a new feature? (yes / **no**)
If yes, how is the feature documented? (not applicable / docs / JavaDocs /
**not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lemonjing/flink csv-close-hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6411
----
commit 6c6120722eef81c2c275b92a13a5687fef35e7bb
Author: lemonjing <932191671@...>
Date: 2018-07-25T05:46:55Z
[hotfix] Flush in ScalaCsvOutputFormat before closing, to ensure CI
stability
----
> Flush in ScalaCsvOutputFormat before close method
> -------------------------------------------------
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Affects Versions: 1.5.1
> Reporter: Rannn Tao
> Assignee: buptljy
> Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
