[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555183#comment-16555183
]
ASF GitHub Bot commented on FLINK-9941:
---------------------------------------
GitHub user buptljy opened a pull request:
https://github.com/apache/flink/pull/6412
[FLINK-9941] Flush in ScalaCsvOutputFormat before close
## What is the purpose of the change
- Flush in ScalaCsvOutputFormat before close.We've already finished it in
org.apache.flink.api.java.io.CsvOutputFormat.
## Brief change log
- add flush in ScalaCsvOutputFormat before close.
## Verifying this change
- unit tests.
## Does this pull request potentially affect one of the following parts:
- no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/buptljy/flink FLINK-9941
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6412.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6412
----
commit 636456d2398bef69a805b96dfb0945459cfcfada
Author: wind <bupt_ljy@...>
Date: 2018-07-25T06:01:36Z
flush ScalaCsvOutputFormat before close
----
> Flush in ScalaCsvOutputFormat before close method
> -------------------------------------------------
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Affects Versions: 1.5.1
> Reporter: Rannn Tao
> Assignee: buptljy
> Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
