[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555908#comment-16555908
]
ASF GitHub Bot commented on FLINK-9941:
---------------------------------------
yanghua commented on issue #6411: [FLINK-9941][ScalaAPI] Flush in
ScalaCsvOutputFormat before closing to ensure CI stability
URL: https://github.com/apache/flink/pull/6411#issuecomment-407812875
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Flush in ScalaCsvOutputFormat before close method
> -------------------------------------------------
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Affects Versions: 1.5.1
> Reporter: Rann Tao
> Assignee: buptljy
> Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
