[
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559501#comment-16559501
]
ASF GitHub Bot commented on FLINK-9885:
---------------------------------------
tzulitai edited a comment on issue #6391: [FLINK-9885] [FLINK-8101] Finalize
Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#issuecomment-408369668
Hi @cjolif, @twalthr, this PR is ready for a second pass now.
- End-to-end tests now pass stably.
- Addressed all of @twalthr's comments
- As for @cjolif's comment on custom configuration for the REST client, I
addressed this by introducing a `RestClientFactory` that offers opportunity for
the user to tweak the `RestClientBuilder`
- I also decided to use a Builder pattern for instantiating the
`ElasticsearchSink`. Along with the new `RestClientFactory`, we would have yet
more constructors, so I felt that using a builder pattern would be a better
idea for the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
> Key: FLINK-9885
> URL: https://issues.apache.org/jira/browse/FLINK-9885
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This
> should also come with an end-to-end test that covers this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
