[
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563627#comment-16563627
]
ASF GitHub Bot commented on FLINK-9885:
---------------------------------------
twalthr commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101]
Finalize Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206511691
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
##########
@@ -97,6 +97,15 @@ public Builder(List<HttpHost> httpHosts,
ElasticsearchSinkFunction<T> elasticsea
this.elasticsearchSinkFunction =
Preconditions.checkNotNull(elasticsearchSinkFunction);
}
+ /**
+ * Sets a map of strings that configures the bulk flushing
behaviour.
+ *
+ * @param bulkRequestsConfig user configuration to configure
bulk flushing behaviour.
+ */
+ public void setBulkRequestsConfig(Map<String, String>
bulkRequestsConfig) {
+ this.bulkRequestsConfig = bulkRequestsConfig;
Review comment:
Check for null. But do we actually need to expose the raw map if it is not
used in ES 6 and later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
> Key: FLINK-9885
> URL: https://issues.apache.org/jira/browse/FLINK-9885
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This
> should also come with an end-to-end test that covers this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
