[
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563625#comment-16563625
]
ASF GitHub Bot commented on FLINK-9885:
---------------------------------------
twalthr commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101]
Finalize Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206503659
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkTestBase.java
##########
@@ -189,4 +191,10 @@ public void runInvalidElasticsearchClusterTest() throws
Exception {
*/
protected abstract ElasticsearchSinkBase<Tuple2<Integer, String>, C>
createElasticsearchSinkForEmbeddedNode(
Map<String, String> userConfig,
ElasticsearchSinkFunction<Tuple2<Integer, String>> elasticsearchSinkFunction)
throws Exception;
+
+ /**
+ * Creates a version-specific Elasticsearch sink to connect to a
specific Elasticsearch node.
+ */
+ protected abstract ElasticsearchSinkBase<Tuple2<Integer, String>, C>
createElasticsearchSinkForNode(
+ Map<String, String> userConfig,
ElasticsearchSinkFunction<Tuple2<Integer, String>> elasticsearchSinkFunction,
String ipAddress) throws Exception;
Review comment:
One line per parameter? Also the line above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
> Key: FLINK-9885
> URL: https://issues.apache.org/jira/browse/FLINK-9885
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This
> should also come with an end-to-end test that covers this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
