kl0u commented on a change in pull request #6437: [FLINK-9976][streaming]
Remove unnecessary generic parameters
URL: https://github.com/apache/flink/pull/6437#discussion_r205851780
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -205,33 +205,40 @@ private StreamingFileSink(
this.rollingPolicy =
DefaultRollingPolicy.create().build();
}
+ RowFormatBuilder(
Review comment:
This constructor can be `private`. Actually also the other constructor could
be, as it is called by the enclosing class, but if it were to move the builder
to a different file, then it would have a problem. So I would recommend to make
the new constructor `private`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
