kl0u commented on a change in pull request #6437: [FLINK-9976][streaming] Remove unnecessary generic parameters URL: https://github.com/apache/flink/pull/6437#discussion_r205851865
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java ########## @@ -275,22 +282,30 @@ private StreamingFileSink( this.bucketer = Preconditions.checkNotNull(bucketer); } + BulkFormatBuilder( Review comment: Same as above, this constructor can be `private` and call this constructor from the previous one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services