tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] 
WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207306976
 
 

 ##########
 File path: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -345,15 +382,20 @@ private void recoverWorkers() throws Exception {
                CompletableFuture<Boolean> stopReconciliationCoordinatorFuture 
= stopActor(reconciliationCoordinator, stopTimeout);
                reconciliationCoordinator = null;
 
 Review comment:
   I think we need to check whether the supporting actors are not null because 
we initialize them only after the `clearStateFuture` has been completed. If 
this takes a bit and someone revokes our leadership in the meantime, 
`clearState` will be called before the support actors have been created.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to