tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos]
WIP
URL: https://github.com/apache/flink/pull/6464#discussion_r207462086
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
##########
@@ -391,13 +391,7 @@ private void recoverWorkers(final
List<MesosWorkerStore.Worker> tasksFromPreviou
@Override
public CompletableFuture<Void> postStop() {
- final CompletableFuture<Void> supportActorsStopFuture =
stopSupportingActorsAsync();
-
- final CompletableFuture<Void> terminationFuture =
super.postStop();
-
- return supportActorsStopFuture.thenCombine(
- terminationFuture,
- (Void voidA, Void voidB) -> null);
+ return super.postStop().thenCompose((ignored) ->
stopSupportingActorsAsync());
Review comment:
I think it should be the other way around. First stop sub class resources
and then parent class resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
