tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] 
WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207463112
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ##########
 @@ -734,8 +734,14 @@ private void clearState() {
                } catch (Exception e) {
                        onFatalError(new ResourceManagerException("Could not 
properly clear the job leader id service.", e));
                }
+               clearState();
        }
 
+       /**
+        * Callback to clear state on leadership revocation.
+        */
+       protected void clearState() {}
 
 Review comment:
   True, I would like this a bit more, because then we don't duplicate this 
logic over multiple different `ResourceManager` implementations if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to