[
https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572961#comment-16572961
]
ASF GitHub Bot commented on FLINK-8290:
---------------------------------------
azagrebin commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r208522780
##########
File path:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
##########
@@ -123,6 +124,7 @@ public SimpleConsumerThread(
this.fetchSize = getInt(config, "fetch.message.max.bytes",
1048576);
this.bufferSize = getInt(config, "socket.receive.buffer.bytes",
65536);
this.reconnectLimit = getInt(config,
"flink.simple-consumer-reconnectLimit", 3);
+ this.clientId = config.getProperty("group.id",
"flink-kafka-consumer-legacy-" + broker.id());
Review comment:
Hi @maqingxiang,
I would suggest to name it `client.id` as in its original description,
because it is used in `SimpleConsumer` eventually in this case and
`FlinkKafkaConsumer08` is based on the `SimpleConsumer`. As `client.id`
identifies application, multiple `group.id`'s can have the same `client.id`. It
should also help in logs and can be set to the same value as `group.id` in the
user config if needed.
`group.id` is also used in the commitment of the offsets in zookeeper for
`FlinkKafkaConsumer08`. It is checked in `ZookeeperOffsetHandler` to be always
set. So if we use it for the `clientId`, `"flink-kafka-consumer-legacy-" +
broker.id()` will be ignored and `client.id` will be coupled with `group.id`
with no way to use it for application name as original documentation suggests.
What do you think?
Cheers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Modify clientId to groupId in flink-connector-kafka-0.8
> -------------------------------------------------------
>
> Key: FLINK-8290
> URL: https://issues.apache.org/jira/browse/FLINK-8290
> Project: Flink
> Issue Type: Improvement
> Reporter: xymaqingxiang
> Assignee: xymaqingxiang
> Priority: Major
> Labels: pull-request-available
>
> Now the Clientid that consumes the all topics are
> constant("flink-kafka-consumer-legacy-" + broker.id()), and it is not easy
> for us to look at kafka's log, so I recommend that it be modified to groupid.
> We can modify the SimpleConsumerThread.java file, as shown below:
> {code:java}
> private final String clientId;
> ...
> this.clientId = config.getProperty("group.id", "flink-kafka-consumer-legacy-"
> + broker.id());
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
