[
https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574930#comment-16574930
]
ASF GitHub Bot commented on FLINK-8290:
---------------------------------------
aljoscha commented on a change in pull request #5304: [FLINK-8290]Modify
clientId to groupId in flink-connector-kafka-0.8
URL: https://github.com/apache/flink/pull/5304#discussion_r208955188
##########
File path:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
##########
@@ -123,6 +124,7 @@ public SimpleConsumerThread(
this.fetchSize = getInt(config, "fetch.message.max.bytes",
1048576);
this.bufferSize = getInt(config, "socket.receive.buffer.bytes",
65536);
this.reconnectLimit = getInt(config,
"flink.simple-consumer-reconnectLimit", 3);
+ this.clientId = config.getProperty("group.id",
"flink-kafka-consumer-legacy-" + broker.id());
Review comment:
Why is it not
```
this.clientId = config.getProperty("client.id",
"flink-kafka-consumer-legacy-" + broker.id());
```
that way the client ID would be configurable separately from the group ID.
As it is in the PR, you can never have a client ID that is different from the
group ID if you set a `group.id`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Modify clientId to groupId in flink-connector-kafka-0.8
> -------------------------------------------------------
>
> Key: FLINK-8290
> URL: https://issues.apache.org/jira/browse/FLINK-8290
> Project: Flink
> Issue Type: Improvement
> Reporter: xymaqingxiang
> Assignee: xymaqingxiang
> Priority: Major
> Labels: pull-request-available
>
> Now the Clientid that consumes the all topics are
> constant("flink-kafka-consumer-legacy-" + broker.id()), and it is not easy
> for us to look at kafka's log, so I recommend that it be modified to groupid.
> We can modify the SimpleConsumerThread.java file, as shown below:
> {code:java}
> private final String clientId;
> ...
> this.clientId = config.getProperty("group.id", "flink-kafka-consumer-legacy-"
> + broker.id());
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
