[
https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658775#comment-14658775
]
ASF GitHub Bot commented on FLINK-2477:
---------------------------------------
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128131074
Hi,
unfortunately the PR still needs a bit of work: The Class documentation
does not match the class. It would be good if the ports where not statically
set since this might interfere with concurrently running jobs. The code could
benefit from a bit of commenting. For example, I don't know why we need to
tests, for invoke and without invoke.
Maybe someone else can take a look? I'm on vacation right now and don't
really have a lot of time.
> Add test for SocketClientSink
> -----------------------------
>
> Key: FLINK-2477
> URL: https://issues.apache.org/jira/browse/FLINK-2477
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Affects Versions: 0.10
> Environment: win7 32bit;linux
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add some tests for SocketClientSink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
