[
https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680593#comment-14680593
]
ASF GitHub Bot commented on FLINK-2477:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129570014
This test actually does not fail if the sink does not work properly. It
contains no assertions, but only prints the status.
Here are a few points that we try to follow:
- The test should assert that the correct result was produced.
- All exceptions should cause the test to fail. That means either
exceptions need to propagate out of the test method, or `Assert.fail()` needs
to be called in the catch block. Be aware that failures in spawned threads need
to be forwarded to the main thread, otherwise the unit test framework will not
work.
- Tests should not print anything, otherwise the terminal will become
unreadable during testing. Output can be made with the logging framework.
> Add test for SocketClientSink
> -----------------------------
>
> Key: FLINK-2477
> URL: https://issues.apache.org/jira/browse/FLINK-2477
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Affects Versions: 0.10
> Environment: win7 32bit;linux
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add some tests for SocketClientSink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
