[
https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659306#comment-14659306
]
ASF GitHub Bot commented on FLINK-2477:
---------------------------------------
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128200510
Hi,
don`t worry and have a nice vacation!
I`ll fix on the Class documentation and the static ports.
As for the tests, I was considering the case coverage.
Everyone could use SocketSinkFunction for invoke and without invoke as the
function is public.
And I would like to combine tests to one test if you think the case
coverage is not necessary.
> Add test for SocketClientSink
> -----------------------------
>
> Key: FLINK-2477
> URL: https://issues.apache.org/jira/browse/FLINK-2477
> Project: Flink
> Issue Type: Test
> Components: Streaming
> Affects Versions: 0.10
> Environment: win7 32bit;linux
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add some tests for SocketClientSink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)