twalthr commented on a change in pull request #6455: [FLINK-9997] [table]
Improve Expression Reduce
URL: https://github.com/apache/flink/pull/6455#discussion_r221917365
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala
##########
@@ -477,6 +476,22 @@ class ExpressionReductionRulesTest extends TableTestBase {
util.verifyTable(result, expected)
}
+ @Test
+ def testReduceDeterministicUDFInBatch(): Unit = {
+ val util = batchTestUtil()
+ val table = util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c)
+
+ // if isDeterministic = true, will cause a Calcite NPE, which will be
fixed in [CALCITE-1860]
Review comment:
Is this comment still valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
