twalthr commented on a change in pull request #6455: [FLINK-9997] [table]
Improve Expression Reduce
URL: https://github.com/apache/flink/pull/6455#discussion_r221924196
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
##########
@@ -136,6 +136,11 @@ object FlinkRuleSets {
FlinkLogicalNativeTableScan.CONVERTER
)
+ val FLINK_LOGICAL_OPT_RULES: RuleSet = RuleSets.ofList(
Review comment:
You mentioned "There's no Calc node at normalize plans, so
ReduceExpressionRule.CALC does not match any thing.". So can we remove it from
`DATASTREAM_NORM_RULES` and `DATASET_NORM_RULES`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
