twalthr commented on a change in pull request #6455: [FLINK-9997] [table]
Improve Expression Reduce
URL: https://github.com/apache/flink/pull/6455#discussion_r221917625
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala
##########
@@ -477,6 +476,22 @@ class ExpressionReductionRulesTest extends TableTestBase {
util.verifyTable(result, expected)
}
+ @Test
+ def testReduceDeterministicUDFInBatch(): Unit = {
Review comment:
Remove duplicate code and add if branch for parts that differ in batch and
streaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services