fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16 
support for TextInputFormat bug fixed
URL: https://github.com/apache/flink/pull/6710#discussion_r221896574
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
 ##########
 @@ -467,6 +477,7 @@ public FileBaseStatistics getStatistics(BaseStatistics 
cachedStats) throws IOExc
         */
        @Override
        public void open(FileInputSplit split) throws IOException {
+               this.bomCharsetName = split.getBomCharsetName();
 
 Review comment:
   We need to make sure that the `this.delimiter` is correctly defined, i.e., 
that the delimiter string is converted to the correct byte sequence (depending 
on the BOM if defined).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to