fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16
support for TextInputFormat bug fixed
URL: https://github.com/apache/flink/pull/6710#discussion_r221898165
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
##########
@@ -221,6 +224,11 @@ public void setCharset(String charset) {
}
}
+ @PublicEvolving
+ public String getBomCharsetName() {
Review comment:
I don't think we should add a new method here because we would need to
update all IFs that extend `DelimitedInputFormat` to use the correct method.
Can we change the `getCharset()` method to return the BOM corrected charset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
