[
https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656383#comment-16656383
]
ASF GitHub Bot commented on FLINK-10002:
----------------------------------------
ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226158300
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobService.java
##########
@@ -123,6 +123,21 @@
*/
TransientBlobKey putTransient(InputStream inputStream) throws
IOException;
+ /**
+ * Uploads a give size of (job-unrelated) data from the given input
stream to the BLOB server.
+ *
+ * @param inputStream
+ * the input stream to read the data from
+ * @param count the size of data to upload to blob server
+ *
+ * @return the computed BLOB key identifying the BLOB on the server
+ *
+ * @throws IOException
+ * thrown if an I/O error occurs while reading the data
from the input stream or uploading the
+ * data to the BLOB server
+ */
+ TransientBlobKey putTransient(InputStream inputStream, long count)
throws IOException;
Review comment:
Actually `InputStream` is enough here. We can put an input stream that
representing partial of the log file. See [`BytesStream.limit() in
guava`](https://google.github.io/guava/releases/19.0/api/docs/com/google/common/io/ByteStreams.html#limit(java.io.InputStream,%20long))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> WebUI shows logs unfriendly, especially when the amount of logs is large
> ------------------------------------------------------------------------
>
> Key: FLINK-10002
> URL: https://issues.apache.org/jira/browse/FLINK-10002
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: zhangxinyu
> Assignee: zhangxinyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments: image-2018-09-10-11-38-07-973.png
>
>
> When a streaming job run for a long time, the amount of logs may be very
> large. The current WebUI shows all content of logs. It will cost much time to
> download logs from task managers. and the browser cannot display the logs.
> Therefore, I suggest that Flink uses DailyRollingAppender to split logs by
> default, and task manager provides an API that can get logs based on a
> parameter of time interval. In this way WebUI can display logs based on time
> interval.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
