[
https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656394#comment-16656394
]
ASF GitHub Bot commented on FLINK-10002:
----------------------------------------
ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226523853
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/files/LogFileHandlerSpecification.java
##########
@@ -25,12 +25,18 @@
* Rest handler specification for the log file of the main cluster component.
*/
public class LogFileHandlerSpecification implements RestHandlerSpecification {
-
- private static final LogFileHandlerSpecification INSTANCE = new
LogFileHandlerSpecification();
-
private static final String URL = "/jobmanager/log";
+ private static final String URL_WITH_RANGE = "/jobmanager/log/:range";
+ private static final String URL_WITH_FILENAME_AND_RANGE =
"/jobmanager/logs/:filename/:range";
- private LogFileHandlerSpecification() {}
+ private static final LogFileHandlerSpecification INSTANCE = new
LogFileHandlerSpecification(URL);
Review comment:
Singleton with multiple instances is not a good idea anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> WebUI shows logs unfriendly, especially when the amount of logs is large
> ------------------------------------------------------------------------
>
> Key: FLINK-10002
> URL: https://issues.apache.org/jira/browse/FLINK-10002
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: zhangxinyu
> Assignee: zhangxinyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments: image-2018-09-10-11-38-07-973.png
>
>
> When a streaming job run for a long time, the amount of logs may be very
> large. The current WebUI shows all content of logs. It will cost much time to
> download logs from task managers. and the browser cannot display the logs.
> Therefore, I suggest that Flink uses DailyRollingAppender to split logs by
> default, and task manager provides an API that can get logs based on a
> parameter of time interval. In this way WebUI can display logs based on time
> interval.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
