[
https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656382#comment-16656382
]
ASF GitHub Bot commented on FLINK-10002:
----------------------------------------
ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226154751
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java
##########
@@ -373,6 +373,54 @@ BlobKey putInputStream(@Nullable JobID jobId, InputStream
inputStream, BlobKey.B
}
}
+ /**
+ * Uploads a given size of data from the given input stream to the BLOB
server.
+ *
+ * @param jobId
+ * the ID of the job the BLOB belongs to (or <tt>null</tt>
if job-unrelated)
+ * @param inputStream
+ * the input stream to read the data from
+ * @param blobType
+ * whether the BLOB should become permanent or transient
+ * @return the computed BLOB key of the uploaded BLOB
+ *
+ * @param count the size of data to upload
+ *
+ * @return the computed BLOB key of the uploaded BLOB
+ *
+ * @throws IOException
+ * thrown if an I/O error occurs while uploading the data
to the BLOB server
+ */
+ BlobKey putInputStream (@Nullable JobID jobId, InputStream inputStream,
BlobKey.BlobType blobType, long count)
Review comment:
```suggestion
BlobKey putInputStream(@Nullable JobID jobId, InputStream inputStream,
BlobKey.BlobType blobType, long count)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> WebUI shows logs unfriendly, especially when the amount of logs is large
> ------------------------------------------------------------------------
>
> Key: FLINK-10002
> URL: https://issues.apache.org/jira/browse/FLINK-10002
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: zhangxinyu
> Assignee: zhangxinyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments: image-2018-09-10-11-38-07-973.png
>
>
> When a streaming job run for a long time, the amount of logs may be very
> large. The current WebUI shows all content of logs. It will cost much time to
> download logs from task managers. and the browser cannot display the logs.
> Therefore, I suggest that Flink uses DailyRollingAppender to split logs by
> default, and task manager provides an API that can get logs based on a
> parameter of time interval. In this way WebUI can display logs based on time
> interval.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
