[
https://issues.apache.org/jira/browse/FLINK-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669846#comment-16669846
]
ASF GitHub Bot commented on FLINK-10600:
----------------------------------------
pnowojski commented on a change in pull request #6924: [FLINK-10600] Provide
End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r229624262
##########
File path: flink-examples/flink-examples-streaming/pom.xml
##########
@@ -60,6 +60,18 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
<version>${project.version}</version>
+ <exclusions>
Review comment:
Why are you excluding this dependency here?
This worries me, because end-to-end tests should be the final validation
that our code works and having to modify dependencies doesn't sound good and
might hide some error
I wonder if maybe a better solution would be to create some separate sub
modules for examples with kafka 0.10 and kafka 2.0?
@tzulitai what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide End-to-end test cases for modern Kafka connectors
> ---------------------------------------------------------
>
> Key: FLINK-10600
> URL: https://issues.apache.org/jira/browse/FLINK-10600
> Project: Flink
> Issue Type: Sub-task
> Components: Kafka Connector
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
