[
https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679327#comment-16679327
]
ASF GitHub Bot commented on FLINK-10820:
----------------------------------------
zhijiangW opened a new pull request #7051: [FLINK-10820][network] Simplify the
RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051
## What is the purpose of the change
*The current `RebalancePartitioner` implementations seems a little hacky for
selecting a random number as the first channel index, and the following
selections based on this random index in round-robin fashion.*
*We can define a constant as the first channel index to make the
implementation simple and readable. To do so, it will not change the rebalance
semantics.*
*In performance aspect, it will reduce some overheads by checking the
condition previously, but it should not have obvious effects. And the key
motivation is not related to performance, just confirm no regression.*
## Brief change log
- *Simplify the implementation of `RebalancePartitioner` in round-robin
way.*
## Verifying this change
This change is already covered by existing tests, such as
*RebalancePartitionerTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify the RebalancePartitioner implementation
> ------------------------------------------------
>
> Key: FLINK-10820
> URL: https://issues.apache.org/jira/browse/FLINK-10820
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> The current {{RebalancePartitioner}} implementations seems a little hacky for
> selecting a random number as the first channel index, and the following
> selections based on this random index in round-robin fashion.
> We can define a constant as the first channel index to make the
> implementation simple and readable. To do so, it will not change the
> rebalance semantics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
