zhijiangW commented on a change in pull request #7186: [FLINK-10941] Keep slots
which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r238189903
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -195,4 +195,10 @@
* @return Future which is completed with the {@link TransientBlobKey}
of the uploaded file.
*/
CompletableFuture<TransientBlobKey> requestFileUpload(FileType
fileType, @RpcTimeout Time timeout);
+
+ /**
+ * Checks whether this can be released. This cannot be released if
there're unconsumed result partitions
+ * @return whether this can be released
+ */
+ boolean canBeReleased();
Review comment:
I think it is better to take CompletableFuture as return type for handling
timeout or failure properly.
@tillrohrmann has the authority for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
