zhijiangW commented on a change in pull request #7186: [FLINK-10941] Keep slots
which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r238191840
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -377,6 +377,13 @@ public void releaseMemory(int toRelease) throws
IOException {
}
}
+ /**
+ * Whether this partition is released (all subpartitions are consumed).
Review comment:
I think we do not need this comment because it is easy to understand or
comment it in above variable `isReleased`?
Canceling task can also enter released state and all subpartitions are not
consumed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
