zhijiangW commented on a change in pull request #7186: [FLINK-10941] Keep slots
which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r238197071
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -61,6 +62,9 @@
/** The readers which are already enqueued available for transferring
data. */
private final ArrayDeque<NetworkSequenceViewReader> availableReaders =
new ArrayDeque<>();
+ /** The readers are marked as to be closed, waiting for confirmation
from writer side */
+ private final Set<NetworkSequenceViewReader> readersToClose = new
HashSet<>();
Review comment:
This set should be cleared in failover cases such as channel inactive and
exception caught. You can refer to the variable `availableReaders`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
