kl0u commented on a change in pull request #7324: [FLINK-10596][cep] Added
access to timer service in IterativeCondition
URL: https://github.com/apache/flink/pull/7324#discussion_r245608763
##########
File path:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java
##########
@@ -804,7 +786,11 @@ private boolean checkFilterCondition(
/**
* The context used when evaluating this computation state.
*/
- private static class ConditionContext<T> implements
IterativeCondition.Context<T> {
+ private class ConditionContext implements IterativeCondition.Context<T>
{
+
+ private final CepTimerService timerService;
+
+ private final long eventTimestamp;
Review comment:
Rename to `eventTimeTimestamp` and have a comment with what the value is in
case there is no event time timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services